[Map-Viewer] Add layer from WFS service #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
jahow
approved these changes
Jan 22, 2024
Comment on lines
114
to
119
| if ('featureCount' in layerModel && layerModel.featureCount) { | ||
| urlObj.searchParams.set( | ||
| 'maxFeatures', | ||
| layerModel.featureCount.toString() | ||
| ) | ||
| } |
There was a problem hiding this comment.
I think we can add this limit every time without having it specified in the context, because having too many objects on the map is always going to be a problem.
| @@ -32,6 +32,7 @@ interface MapContextLayerWfsModel { | |||
| type: 'wfs' | |||
| url: string | |||
| name: string | |||
| featureCount?: number | |||
There was a problem hiding this comment.
See other comment, this shouldn't be necessary
|
|
||
| this.wfsEndpoint = await new WfsEndpoint(this.wfsUrl).isReady() | ||
| this.layers = this.wfsEndpoint.getFeatureTypes() | ||
| console.log(this.layers) |
There was a problem hiding this comment.
This line can be removed I think 🙂 did we forget a console.log in WMS as well?
ronitjadhav
force-pushed
the
mv-add-from-wfs
branch
2 times, most recently
from
d19b555 to
80decb8
Compare
ronitjadhav
force-pushed
the
mv-add-from-wfs
branch
from
80decb8 to
78bfee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the feature that allows users to add a layer from a Web Feature Service (WFS) to their map.
add-layer-from-wfscomponent insrc/app/components/add-layer-from-wfs/add-layer-from-wfs.component.tsmap-context.service.tsandmap-context.model.tsto add an option which limits WFS features countTask List:
Screenshots:
#756